[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] linux-user/syscall.c: Need call unlock_user() b
From: |
Chen Gang S |
Subject: |
Re: [Qemu-devel] [PATCH] linux-user/syscall.c: Need call unlock_user() before go to failure return in default case |
Date: |
Fri, 23 Jan 2015 18:19:53 +0800 |
User-agent: |
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 |
On 1/23/15 18:01, Peter Maydell wrote:
> On 23 January 2015 at 08:53, Chen Gang S <address@hidden> wrote:
>> In abi_long do_ioctl_dm(), after calls lock_user(), it does not call
>> unlock_user() before go to failure return in default case.
>>
>> Signed-off-by: Chen Gang <address@hidden>
>> ---
>> linux-user/syscall.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
>> index aaac6a2..290fdea 100644
>> --- a/linux-user/syscall.c
>> +++ b/linux-user/syscall.c
>> @@ -3681,6 +3681,7 @@ static abi_long do_ioctl_dm(const IOCTLEntry *ie,
>> uint8_t *buf_temp, int fd,
>> }
>> default:
>> ret = -TARGET_EINVAL;
>> + unlock_user(argptr, guest_data, 0);
>> goto out;
>> }
>> unlock_user(argptr, guest_data, guest_data_size);
>> --
>> 1.9.3 (Apple Git-50)
>
> Correct as far as it goes, but notice that we have the identical
> bug in the other switch (ie->host_cmd) as well...
>
Oh, really, thanks. I shall send patch v2 for it, if no additional reply
within 2 days.
Thanks.
--
Chen Gang
Open, share, and attitude like air, water, and life which God blessed