[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 5/7] cutils: refine strtol error handling in parse_d
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] [PATCH 5/7] cutils: refine strtol error handling in parse_debug_env |
Date: |
Mon, 26 Jan 2015 12:12:25 +0100 |
Avoid truncation of a 64-bit long to a 32-bit int, and check for errno
(especially ERANGE).
Signed-off-by: Paolo Bonzini <address@hidden>
---
util/cutils.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/util/cutils.c b/util/cutils.c
index dbe7412..f227064 100644
--- a/util/cutils.c
+++ b/util/cutils.c
@@ -523,7 +523,7 @@ int parse_debug_env(const char *name, int max, int initial)
{
char *debug_env = getenv(name);
char *inv = NULL;
- int debug;
+ long debug;
if (!debug_env) {
return initial;
@@ -532,7 +532,7 @@ int parse_debug_env(const char *name, int max, int initial)
if (inv == debug_env) {
return initial;
}
- if (debug < 0 || debug > max) {
+ if (debug < 0 || debug > max || errno != 0) {
fprintf(stderr, "warning: %s not in [0, %d]", name, max);
return initial;
}
--
1.8.3.1
- [Qemu-devel] [PATCH 0/7] Six coverity fixes and a cleanup, Paolo Bonzini, 2015/01/26
- [Qemu-devel] [PATCH 2/7] cpu-exec: simplify icount code, Paolo Bonzini, 2015/01/26
- [Qemu-devel] [PATCH 3/7] uri: avoid NULL arguments to strcmp, Paolo Bonzini, 2015/01/26
- [Qemu-devel] [PATCH 4/7] qemu-sockets: improve error reporting in unix_listen_opts, Paolo Bonzini, 2015/01/26
- [Qemu-devel] [PATCH 5/7] cutils: refine strtol error handling in parse_debug_env,
Paolo Bonzini <=
- [Qemu-devel] [PATCH 1/7] cpu-exec: drop dead assignment, Paolo Bonzini, 2015/01/26
- [Qemu-devel] [PATCH 6/7] aes: remove a dead return statement, Paolo Bonzini, 2015/01/26
- [Qemu-devel] [PATCH 7/7] migration: do floating-point division, Paolo Bonzini, 2015/01/26