[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Spice-devel] [PATCH] [RFC] LZ4 compression option for
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [Spice-devel] [PATCH] [RFC] LZ4 compression option for SPICE |
Date: |
Mon, 26 Jan 2015 09:25:04 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 |
On 01/26/2015 01:48 AM, Javier Celaya wrote:
> Sorry, I forgot to patch the command-line help. Hope it helps.
>
>>>
>>> Recently, SPICE included the lz4 compression algorithm. This patch adds
>>> a command line option to select it.
>>
>> How is libvirt going to introspect whether the command line supports
>> this option? Is there some QMP command that lists the set of valid
>> compression formats understood by a given qemu binary?
No, patching the command line --help does NOT help libvirt. It needs to
be discoverable via QMP to be introspectible, as scraping --help output
is not machine-friendly. (That said, you DO want to expose it in --help
output; I'm just complaining that --help output alone is not enough).
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH] [RFC] LZ4 compression option for SPICE, Javier Celaya, 2015/01/08
- Re: [Qemu-devel] [PATCH] [RFC] LZ4 compression option for SPICE, Gerd Hoffmann, 2015/01/08
- Re: [Qemu-devel] [Spice-devel] [PATCH] [RFC] LZ4 compression option for SPICE, Fabio Fantoni, 2015/01/08
- Re: [Qemu-devel] [Spice-devel] [PATCH] [RFC] LZ4 compression option for SPICE, Christophe Fergeau, 2015/01/20
- Re: [Qemu-devel] [Spice-devel] [PATCH] [RFC] LZ4 compression option for SPICE, Javier Celaya, 2015/01/23
- Re: [Qemu-devel] [Spice-devel] [PATCH] [RFC] LZ4 compression option for SPICE, Eric Blake, 2015/01/23
- Re: [Qemu-devel] [Spice-devel] [PATCH] [RFC] LZ4 compression option for SPICE, Javier Celaya, 2015/01/26
- Re: [Qemu-devel] [Spice-devel] [PATCH] [RFC] LZ4 compression option for SPICE,
Eric Blake <=
- Re: [Qemu-devel] [Spice-devel] [PATCH] [RFC] LZ4 compression option for SPICE, Markus Armbruster, 2015/01/27
- Re: [Qemu-devel] [Spice-devel] [PATCH] [RFC] LZ4 compression option for SPICE, Javier Celaya, 2015/01/28
- Re: [Qemu-devel] [Spice-devel] [PATCH] [RFC] LZ4 compression option for SPICE, Markus Armbruster, 2015/01/28