[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 04/21] block: Add bdrv_close_all() handlers
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH 04/21] block: Add bdrv_close_all() handlers |
|
Date: |
Mon, 26 Jan 2015 22:22:14 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 |
On 26/01/2015 22:13, Max Reitz wrote:
>>>
>> An eject blocker would also break backwards-compatibility though. What
>> about an eject notifier? Would that concept make sense?
>
> It does make sense (in that it is the way I would implement "just do
> what we always did"), but I just don't like it for the fact that it
> makes NBD a special snowflake. I can live with it, though.
Yes, it's weird. But this is just the backwards-compatible solution.
I'm okay with implementing only the new solution, but:
- the old QMP (and HMP?) commands must be removed
- the new command probably must not reuse the same BB as the guest, and
I am not sure that this is possible.
Paolo
- Re: [Qemu-devel] [PATCH 08/21] block: Make bdrv_close() static, (continued)
- [Qemu-devel] [PATCH 03/21] block: Add bdrv_close_all() notifiers, Max Reitz, 2015/01/26
- [Qemu-devel] [PATCH 09/21] block: Add blk_name_taken(), Max Reitz, 2015/01/26
- [Qemu-devel] [PATCH 04/21] block: Add bdrv_close_all() handlers, Max Reitz, 2015/01/26
- Re: [Qemu-devel] [PATCH 04/21] block: Add bdrv_close_all() handlers, Paolo Bonzini, 2015/01/26
- Re: [Qemu-devel] [PATCH 04/21] block: Add bdrv_close_all() handlers, Max Reitz, 2015/01/26
- Re: [Qemu-devel] [PATCH 04/21] block: Add bdrv_close_all() handlers, Paolo Bonzini, 2015/01/26
- Re: [Qemu-devel] [PATCH 04/21] block: Add bdrv_close_all() handlers, Max Reitz, 2015/01/26
- Re: [Qemu-devel] [PATCH 04/21] block: Add bdrv_close_all() handlers,
Paolo Bonzini <=
- Re: [Qemu-devel] [PATCH 04/21] block: Add bdrv_close_all() handlers, Eric Blake, 2015/01/28
- Re: [Qemu-devel] [PATCH 04/21] block: Add bdrv_close_all() handlers, Max Reitz, 2015/01/28
- Re: [Qemu-devel] [PATCH 04/21] block: Add bdrv_close_all() handlers, Paolo Bonzini, 2015/01/29
Re: [Qemu-devel] [PATCH 04/21] block: Add bdrv_close_all() handlers, Eric Blake, 2015/01/28
[Qemu-devel] [PATCH 05/21] block: Remove per-BDS close notifiers, Max Reitz, 2015/01/26
[Qemu-devel] [PATCH 10/21] block: Add blk_next_inserted(), Max Reitz, 2015/01/26
[Qemu-devel] [PATCH 02/21] quorum: Fix close path, Max Reitz, 2015/01/26