Re: [Qemu-devel] [PATCH v3 06/14] qemu-img: Use blk_new_open() in img_rebase()

[Max Reitz]

On 2015-01-26 at 22:05, Eric Blake wrote:
> On 01/26/2015 08:00 AM, Max Reitz wrote:
> > Signed-off-by: Max Reitz <address@hidden>
> > ---
> >   qemu-img.c | 57 ++++++++++++++++++++++++---------------------------------
> >   1 file changed, 24 insertions(+), 33 deletions(-)
> >
> > -
> >       /* For safe rebasing we need to compare old and new backing file */
> >       if (!unsafe) {
> >           char backing_name[PATH_MAX];
> > +        QDict *options = NULL;
> > +
> > +        if (!unsafe && bs->backing_format[0] != '\0') {
> Useless conditional ('!unsafe' is always true here).

Oh, right, thanks.

Max

> With that fixed,
> Reviewed-by: Eric Blake <address@hidden>