[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCHv2 1/2] vl.c: Fix error messages when parsing max
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCHv2 1/2] vl.c: Fix error messages when parsing maxmem parameters |
Date: |
Wed, 28 Jan 2015 19:32:08 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) |
Igor Mammedov <address@hidden> writes:
> On Wed, 28 Jan 2015 17:21:28 +0100
> Peter Krempa <address@hidden> wrote:
>
>> On Wed, Jan 28, 2015 at 13:29:41 +0100, Igor Mammedov wrote:
>> > On Wed, 28 Jan 2015 09:35:03 +0100
>> > Peter Krempa <address@hidden> wrote:
>> >
>> > > Produce more human readable error messages and fix few spelling
>> > > mistakes.
>> > >
>> > > Also remove a redundant check for the max memory size.
>> > >
>> > > Signed-off-by: Peter Krempa <address@hidden>
>> > > ---
>> > >
>> > > Notes:
>> > > Version 2:
>> > > - fixed spacing in error message
>> > > - changed control flow to allow maxmem == ram_size in case slots == 0
>> > >
>> > > vl.c | 34 ++++++++++++++++------------------
>> > > 1 file changed, 16 insertions(+), 18 deletions(-)
>> > >
>> > > diff --git a/vl.c b/vl.c
>> > > index 983259b..5a012f4 100644
>> > > --- a/vl.c
>> > > +++ b/vl.c
>> > > @@ -2694,29 +2694,27 @@ static void set_memory_options(uint64_t
>> > > *ram_slots, ram_addr_t *maxram_size)
>> > > uint64_t slots;
>> > >
>> > > sz = qemu_opt_get_size(opts, "maxmem", 0);
>> > > + slots = qemu_opt_get_number(opts, "slots", 0);
>> > > if (sz < ram_size) {
>> > > - error_report("invalid -m option value: maxmem "
>> > > - "(0x%" PRIx64 ") <= initial memory (0x"
>> > > - RAM_ADDR_FMT ")", sz, ram_size);
>> > > + error_report("invalid value of -m option maxmem: "
>> > > + "maximum memory size (0x%" PRIx64 ") must at
>> > > least "
>> > typo??
>> > "must be at least"
>> >
>>
>> Hmm, right. Should I respin the series to fix it?
> Send an extra incremental patch with subject:
> "fixup! vl.c: Fix error messages when parsing maxmem parameters"
I'd simply respin, especially a small series like this one.
[Qemu-devel] [PATCHv2 2/2] pc: memory: Validate alignment of maxram_size to page size, Peter Krempa, 2015/01/28