Re: [Qemu-devel] [RFC PATCH v8 04/21] replay: internal functions for replay log

[Pavel Dovgaluk]

> From: Paolo Bonzini [mailto:address@hidden
> On 22/01/2015 09:51, Pavel Dovgalyuk wrote:
> > This patch adds functions to perform read and write operations
> > with replay log.
> >
> > Signed-off-by: Pavel Dovgalyuk <address@hidden>
> > ---
> > +void replay_check_error(void)
> 
> Could this be static? (I haven't checked).

No, because it is used from several replay files.

> > +{
> > +    if (replay_file) {
> > +        if (feof(replay_file)) {
> > +            fprintf(stderr, "replay file is over\n");
> > +            exit(1);
> 
> Perhaps qemu_system_vmstop_request_prepare +
> qemu_system_vmstop_request(RUN_STATE_PAUSED) instead of exit?  Those two
> functions are thread-safe.

There is no need to stop when replay file is over (because we cannot replay 
more).
Should we send shutdown request instead?


Pavel Dovgalyuk