[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 14/21] blockdev: Remove blk_hide_on_behalf_of_do
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 14/21] blockdev: Remove blk_hide_on_behalf_of_do_drive_del() |
Date: |
Fri, 30 Jan 2015 10:44:54 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 |
On 01/26/2015 12:27 PM, Max Reitz wrote:
> This function first removed the BlockBackend from the blk_backends list
> and cleared its name so it would no longer be found by blk_name(); since
> blk_next() now iterates through monitor_block_backends (which the BB is
> removed from in do_drive_del()), this is no longer necessary.
>
> Second, bdrv_make_anon() was called on the BDS. This was intended for
> cases where the BDS was owned by that BB alone; in which case the BDS
> will no longer exist at this point thanks to the blk_remove_bs() in
> do_drive_del().
>
> Therefore, this function does nothing useful anymore. Remove it.
>
> Signed-off-by: Max Reitz <address@hidden>
> ---
> block/block-backend.c | 25 ++-----------------------
> blockdev.c | 1 -
> include/sysemu/block-backend.h | 2 --
> 3 files changed, 2 insertions(+), 26 deletions(-)
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH 04/21] block: Add bdrv_close_all() handlers, (continued)
- [Qemu-devel] [PATCH 05/21] block: Remove per-BDS close notifiers, Max Reitz, 2015/01/26
- [Qemu-devel] [PATCH 10/21] block: Add blk_next_inserted(), Max Reitz, 2015/01/26
- [Qemu-devel] [PATCH 02/21] quorum: Fix close path, Max Reitz, 2015/01/26
- [Qemu-devel] [PATCH 14/21] blockdev: Remove blk_hide_on_behalf_of_do_drive_del(), Max Reitz, 2015/01/26
- Re: [Qemu-devel] [PATCH 14/21] blockdev: Remove blk_hide_on_behalf_of_do_drive_del(),
Eric Blake <=
- [Qemu-devel] [PATCH 16/21] block: Move some bdrv_*_all() functions to BB, Max Reitz, 2015/01/26
- [Qemu-devel] [PATCH 12/21] block: Use BlockBackend more, Max Reitz, 2015/01/26
- [Qemu-devel] [PATCH 15/21] block: Make bdrv_drain_one() public, Max Reitz, 2015/01/26
- [Qemu-devel] [PATCH 11/21] block: Add blk_commit_all() and blk_invalidate_cache_all(), Max Reitz, 2015/01/26
- [Qemu-devel] [PATCH 17/21] block: Remove bdrv_states, Max Reitz, 2015/01/26
- [Qemu-devel] [PATCH 13/21] blockdev: Add list of monitor-owned BlockBackends, Max Reitz, 2015/01/26