qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 4/4] linux-user: initialize progname with err


From: Hitoshi Mitake
Subject: Re: [Qemu-devel] [PATCH v2 4/4] linux-user: initialize progname with error_set_progname()
Date: Mon, 02 Feb 2015 18:47:27 +0900
User-agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (Goj$(D+W(B) APEL/10.8 Emacs/24.3 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO)

Hi Peter,
Sorry for my late reply.

At Thu, 22 Jan 2015 10:07:27 +0000,
Peter Maydell wrote:
> 
> On 22 January 2015 at 09:08, Hitoshi Mitake
> <address@hidden> wrote:
> > Calling error_get_progname() in the context of qemu-x86_64 can cause
> > segmentation fault because linux-user/main.c doesn't initialize its
> > progname with error_set_progname(). This patch adds the
> > initialization.
> >
> > Currently, the missing call of error_set_progname() doesn't cause any
> > problems because qemu-x86_64 doesn't use error_get_progname(). This
> > patch is a proactive action.
> 
> I don't think this patch is right. The *-user binaries don't
> (and should not) use the qemu-error infrastructure (they don't
> have the monitor or any of the other stuff that uses). Code
> which tries to use error_get_progname() in *-user would be
> broken.

I just thought linux-user would be a potential user of the qemu-error
infrastructure because it is liked with util/qemu-error.o. Actually,
the changes of the patch (let linux-user/main.c include
"qemu/error-report.h" and call error_get_progname()) didn't cause any
problems.

But I'm not familiar with linux-user. If the command should never be a
user of the error infrastructure, I'd like to drop this patch, of
course.

Thanks,
Hitoshi






reply via email to

[Prev in Thread] Current Thread [Next in Thread]