[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] Fix ABI incompatibility between Qemu-aarch64 an

From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH] Fix ABI incompatibility between Qemu-aarch64 and Linux Kernel in signal handling.
Date: Mon, 2 Feb 2015 14:56:40 +0000

On 2 February 2015 at 13:52, Maxim Ostapenko
<address@hidden> wrote:
> Peter,
> thank you for review and sorry for sign. I've updated the patch, is it ok
> now?

The code looks ok, but...

> From 5b035df58f9f17e64b35311b6b5f55097c7f8ce1 Mon Sep 17 00:00:00 2001
> From: Max Ostapenko <address@hidden>
> Date: Mon, 2 Feb 2015 12:03:20 +0400
> Subject: [PATCH] linux-user: wrong TARGET_SI_PAD_SIZE value for some
> targets.
> Fix TARGET_SI_PAD_SIZE for S390X, SPARC, ALPHA and AARCH64 according to
> Linux Kernel 3.19 c59c961ca511dc7ee2f4f7e9c224d16f5c76ca6e revision.

Your signed-off-by line should go here, in the commit message
(one blank line, then the signoff; look at other commits in
git to see how this should look).

Also that part about s390x/sparc/alpha/aarch64 in the commit
message isn't accurate now the code has changed.

It's also best to send new versions of a patch as complete
new emails, not as followups to the previous one. That way
automated tools for tracking and downloading patches from
the mailing list will function correctly.

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]