[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH 0/3] softfloat: Remove STATUS macros

From: Peter Maydell
Subject: [Qemu-devel] [PATCH 0/3] softfloat: Remove STATUS macros
Date: Mon, 2 Feb 2015 20:31:33 +0000

This patchset expands out all the uses of the softfloat STATUS_VAR,
STATUS_PARAM and STATUS macros and removes their definitions.

In my opinion these macros are basically just obfuscating the
passing around and use of a float_status pointer in the softfloat
code, and serve no useful purpose. I used to think that we should
retain them on the offchance we wanted to pull in new softfloat
upstream code, but this is wrong on three counts now:
 (1) there's never been any new softfloat upstream code to take
 (2) even if there were, we couldn't take it because of the license
 (3) these macros aren't even in the upstream version; they were
     added by Fabrice when he integrated softfloat into QEMU

We've never used whatever flexibility might in theory be
permitted by the indirection through this set of macros, so
this patchset just deletes them all.

The changes make an alarmingly large diffstat, but it's just
mechanical expansion plus fixing of coding style issues on the
affected lines. (Lots of style fixing because the softfloat
upstream coding is (a) a long way away from QEMU's and (b) bonkers.)

This obviously is likely to induce merge conflicts with any
other in-flight softfloat changes, for which I apologise in

[Next on the cleanup list: get rid of those 'int8/int32/int64'

Peter Maydell (3):
  softfloat: Expand out the STATUS_PARAM macro
  softfloat: expand out STATUS_VAR
  softfloat: expand out STATUS macro

 fpu/softfloat-specialize.h |  124 ++--
 fpu/softfloat.c            | 1609 ++++++++++++++++++++++++--------------------
 include/fpu/softfloat.h    |  371 +++++-----
 target-mips/msa_helper.c   |   74 +-
 4 files changed, 1188 insertions(+), 990 deletions(-)


reply via email to

[Prev in Thread] Current Thread [Next in Thread]