[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 2/4] target-arm: Add feature parsing to virt
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH v3 2/4] target-arm: Add feature parsing to virt |
Date: |
Tue, 3 Feb 2015 19:10:49 +0000 |
On 27 January 2015 at 23:58, Greg Bellows <address@hidden> wrote:
> Added machvirt parsing of feature keywords added to the -cpu command line
> option. Parsing occurs during machine initialization.
> - vbi = find_machine_info(cpu_model);
> + /* Separate the actual CPU model name from any appended features */
> + cpustr = g_strsplit(cpu_model, ",", 2);
> +
> + vbi = find_machine_info(cpustr[0]);
It seems a shame we have to do this kind of manual string
fiddling in every board model, but that is definitely not a
problem to address in this patchset.
> @@ -604,6 +610,13 @@ static void machvirt_init(MachineState *machine)
> }
> cpuobj = object_new(object_class_get_name(oc));
>
> + /* Handle any CPU options specfied by the user */
"specified"
> + cc->parse_features(CPU(cpuobj), cpustr[1], &err);
> + if (err) {
> + error_report("%s", error_get_pretty(err));
> + exit(1);
> + }
Otherwise
Reviewed-by: Peter Maydell <address@hidden>
thanks
-- PMM
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH v3 2/4] target-arm: Add feature parsing to virt,
Peter Maydell <=