Re: [Qemu-devel] [PATCH RFC v2 7/8] migration: add dirty parameter

[Vladimir Sementsov-Ogievskiy]

On 27.01.2015 19:20, Eric Blake wrote:
> On 01/27/2015 03:56 AM, Vladimir Sementsov-Ogievskiy wrote:
> > Add dirty parameter to qmp-migrate command. If this parameter is true,
> > migration/block.c will migrate dirty bitmaps. This parameter can be used
> > without "blk" parameter to migrate only dirty bitmaps, skipping block
> > migration.
> >
> > Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
> > ---
> > +++ b/qapi-schema.json
> > @@ -1656,12 +1656,17 @@
> >   # @detach: this argument exists only for compatibility reasons and
> >   #          is ignored by QEMU
> >   #
> > +# @dirty: #optional do dirty-bitmaps migration (can be used with or without
> > +#         @blk parameter)
> > +#         (since 2.3)
> Rather than adding it to 'migrate', where the command is not
> introspectible, I'd rather you add it to 'migrate-set-capabilities',
> where I can then use 'query-migrate-capabilities' to learn if it is
> supported.
Thank you. Moreover, it is turned out to be a simpler way than with 
migration parameter. I've done the change, it will be in v3. I'm just 
waiting for review of the core part of the series - migration/dirty-bitmap.c

--
Best regards,
Vladimir