[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH v8 12/21] replay: recording and replaying di
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [RFC PATCH v8 12/21] replay: recording and replaying different timers |
|
Date: |
Wed, 04 Feb 2015 16:20:33 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 |
On 03/02/2015 15:05, Pavel Dovgaluk wrote:
>> >
>> > What about just making qemu_get_timedate use
>> > qemu_clock_get_ns(QEMU_CLOCK_HOST) instead of time()? This would just
>> > work using the infrastructure of the previous patch.
> I can get rid of these calls, but localtime() function used
> in qemu_get_timedate() will not work deterministically.
> Should we save its' result then?
It is deterministic if the user's timezone remains the same. You could
just outlaw "-rtc base=localtime".
Also, if you choose to record the output of qemu_get_timedate(), you
have to do the same for qemu_timedate_diff(). Switching
qemu_timedate_diff to use QEMU_CLOCK_HOST would also work for
qemu_timedate_diff().
Paolo