[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 03/12] qcow2: Create metadata list

From: Max Reitz
Subject: Re: [Qemu-devel] [PATCH v2 03/12] qcow2: Create metadata list
Date: Wed, 04 Feb 2015 11:31:24 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0

On 2015-02-03 at 18:34, Eric Blake wrote:
On 11/24/2014 08:56 AM, Max Reitz wrote:
Create and destroy the metadata list on creation and destruction of a
qcow2 BDS, respectively. Skip creation if no overlap checks should be

Signed-off-by: Max Reitz <address@hidden>
  block/qcow2.c | 10 ++++++++++
  1 file changed, 10 insertions(+)

diff --git a/block/qcow2.c b/block/qcow2.c
index ed88d69..f80f9ed 100644
--- a/block/qcow2.c
+++ b/block/qcow2.c
@@ -744,6 +744,13 @@ static int qcow2_open(BlockDriverState *bs, QDict 
*options, int flags,
                                overlap_check_template & (1 << i)) << i;
+ if (s->overlap_check) {
+        ret = qcow2_create_empty_metadata_list(bs, 65536, errp);
Why 64k? Does this magic number need a name?

Well, maybe I should add a comment "TODO: The user should be able to override this default".

Reviewed-by: Eric Blake <address@hidden>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]