[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 5/7] numa: Move QemuOpts parsing to set_numa_nodes()
From: |
Eduardo Habkost |
Subject: |
[Qemu-devel] [PATCH 5/7] numa: Move QemuOpts parsing to set_numa_nodes() |
Date: |
Sun, 8 Feb 2015 16:51:20 -0200 |
This allows us to make numa_init_func() static.
Signed-off-by: Eduardo Habkost <address@hidden>
---
include/sysemu/numa.h | 1 -
numa.c | 9 ++++++++-
vl.c | 5 -----
3 files changed, 8 insertions(+), 7 deletions(-)
diff --git a/include/sysemu/numa.h b/include/sysemu/numa.h
index eae881e..d25ada9 100644
--- a/include/sysemu/numa.h
+++ b/include/sysemu/numa.h
@@ -20,6 +20,5 @@ void set_numa_nodes(void);
void set_numa_modes(void);
void query_numa_node_mem(uint64_t node_mem[]);
extern QemuOptsList qemu_numa_opts;
-int numa_init_func(QemuOpts *opts, void *opaque);
#endif
diff --git a/numa.c b/numa.c
index 84d4cb5..eb9259b 100644
--- a/numa.c
+++ b/numa.c
@@ -36,6 +36,8 @@
#include "sysemu/hostmem.h"
#include "qmp-commands.h"
#include "hw/mem/pc-dimm.h"
+#include "qemu/option.h"
+#include "qemu/config-file.h"
QemuOptsList qemu_numa_opts = {
.name = "numa",
@@ -121,7 +123,7 @@ static void numa_node_parse(NumaNodeOptions *node, QemuOpts
*opts, Error **errp)
max_numa_nodeid = MAX(max_numa_nodeid, nodenr + 1);
}
-int numa_init_func(QemuOpts *opts, void *opaque)
+static int numa_init_func(QemuOpts *opts, void *opaque)
{
NumaOptions *object = NULL;
Error *err = NULL;
@@ -168,6 +170,11 @@ void set_numa_nodes(void)
{
int i;
+ if (qemu_opts_foreach(qemu_find_opts("numa"), numa_init_func,
+ NULL, 1) != 0) {
+ exit(1);
+ }
+
assert(max_numa_nodeid <= MAX_NODES);
/* No support for sparse NUMA node IDs yet: */
diff --git a/vl.c b/vl.c
index 5adea75..cfce820 100644
--- a/vl.c
+++ b/vl.c
@@ -4154,11 +4154,6 @@ int main(int argc, char **argv, char **envp)
default_drive(default_floppy, snapshot, IF_FLOPPY, 0, FD_OPTS);
default_drive(default_sdcard, snapshot, IF_SD, 0, SD_OPTS);
- if (qemu_opts_foreach(qemu_find_opts("numa"), numa_init_func,
- NULL, 1) != 0) {
- exit(1);
- }
-
set_numa_nodes();
if (qemu_opts_foreach(qemu_find_opts("mon"), mon_init_func, NULL, 1) != 0)
{
--
2.1.0
- [Qemu-devel] [PATCH 0/7] NUMA code cleanup, Eduardo Habkost, 2015/02/08
- [Qemu-devel] [PATCH 3/7] numa: Move NUMA globals to numa.c, Eduardo Habkost, 2015/02/08
- [Qemu-devel] [PATCH 4/7] numa: Make max_numa_nodeid static, Eduardo Habkost, 2015/02/08
- [Qemu-devel] [PATCH 2/7] vl.c: Remove unnecessary zero-initialization of NUMA globals, Eduardo Habkost, 2015/02/08
- [Qemu-devel] [PATCH 5/7] numa: Move QemuOpts parsing to set_numa_nodes(),
Eduardo Habkost <=
- [Qemu-devel] [PATCH 1/7] numa: Move NUMA declarations from sysemu.h to numa.h, Eduardo Habkost, 2015/02/08
- [Qemu-devel] [PATCH 6/7] numa: Rename option parsing functions, Eduardo Habkost, 2015/02/08
- [Qemu-devel] [PATCH 7/7] numa: Rename set_numa_modes() to numa_post_machine_init(), Eduardo Habkost, 2015/02/08
- Re: [Qemu-devel] [PATCH 0/7] NUMA code cleanup, Paolo Bonzini, 2015/02/09