[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH v3] tests: rtl8139: test timers and interrup
Re: [Qemu-devel] [RFC PATCH v3] tests: rtl8139: test timers and interrupt
Mon, 9 Feb 2015 10:21:15 +0000
On Fri, Feb 06, 2015 at 05:07:17PM +0000, Frediano Ziglio wrote:
> 2015-02-06 16:54 GMT+00:00 Stefan Hajnoczi <address@hidden>:
> > On Thu, Jan 08, 2015 at 06:38:23PM +0000, Frediano Ziglio wrote:
> >> Test behaviour of timers and interrupts related to timeouts.
> >> Signed-off-by: Frediano Ziglio <address@hidden>
> >> ---
> >> tests/Makefile | 2 +-
> >> tests/rtl8139-test.c | 181
> >> +++++++++++++++++++++++++++++++++++++++++++++++++++
> >> 2 files changed, 182 insertions(+), 1 deletion(-)
> >> This patch was derived from a test I did while implementing timer in
> >> rtl8139 code. Now that there is support for integrated testing I converted
> >> it. The test was tested on a real NIC.
> >> As if it's the first test I wrote I don't know if syntax and details are
> >> fine. For instance should I remove nop test? Should I split my test?
> >> Changed from v2:
> >> - style (variable declaration, Perl script not able to spot it)
> >> Changed from v1:
> >> - style
> > Thanks, applied to my net tree:
> > https://github.com/stefanha/qemu/commits/net
> all the comments seems to refer to my patch for testing the card but
> from https://github.com/stefanha/qemu/commits/net looks like you
> applied Paolo patch.
> Is it expected?
Sorry, it didn't make it into last week's net pull request due to a
It will be included in the next net pull request:
Description: PGP signature