[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 12/46] linux-user/syscall.c: do_ioctl_dm: Need to cal
From: |
Michael Tokarev |
Subject: |
[Qemu-devel] [PULL 12/46] linux-user/syscall.c: do_ioctl_dm: Need to call unlock_user() before going to failure return in default case |
Date: |
Tue, 10 Feb 2015 09:34:01 +0300 |
From: Chen Gang S <address@hidden>
In abi_long do_ioctl_dm(), after lock_user() call, the code does
not call unlock_user() before going to failure return in default case.
Signed-off-by: Chen Gang <address@hidden>
Reviewed-by: Peter Maydell <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>
---
linux-user/syscall.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 310080c..5720195 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -3576,6 +3576,7 @@ static abi_long do_ioctl_dm(const IOCTLEntry *ie, uint8_t
*buf_temp, int fd,
}
default:
ret = -TARGET_EINVAL;
+ unlock_user(argptr, guest_data, 0);
goto out;
}
unlock_user(argptr, guest_data, 0);
@@ -3695,6 +3696,7 @@ static abi_long do_ioctl_dm(const IOCTLEntry *ie, uint8_t
*buf_temp, int fd,
break;
}
default:
+ unlock_user(argptr, guest_data, 0);
ret = -TARGET_EINVAL;
goto out;
}
--
2.1.4
- [Qemu-devel] [PULL 00/46] Trivial patches for 2015-02-10, Michael Tokarev, 2015/02/10
- [Qemu-devel] [PULL 08/46] virtfs-proxy-helper: Fix possible socket leak., Michael Tokarev, 2015/02/10
- [Qemu-devel] [PULL 04/46] Add trace to ps2.c., Michael Tokarev, 2015/02/10
- [Qemu-devel] [PULL 12/46] linux-user/syscall.c: do_ioctl_dm: Need to call unlock_user() before going to failure return in default case,
Michael Tokarev <=
- [Qemu-devel] [PULL 34/46] rdma: g_malloc0() can't fail, bury dead error handling, Michael Tokarev, 2015/02/10
- [Qemu-devel] [PULL 36/46] translate-all: Use g_try_malloc() for dynamic translator buffer, Michael Tokarev, 2015/02/10
- [Qemu-devel] [PULL 37/46] disas/cris: Fix warning caused by missing 'static' attribute, Michael Tokarev, 2015/02/10
- [Qemu-devel] [PULL 02/46] fw_cfg: fix typos in comments: patch -> path, Michael Tokarev, 2015/02/10
- [Qemu-devel] [PULL 41/46] moxie: Fix warning caused by missing include statement, Michael Tokarev, 2015/02/10
- [Qemu-devel] [PULL 01/46] target-mips: Clean up switch fall through after commit fecd264, Michael Tokarev, 2015/02/10
- [Qemu-devel] [PULL 06/46] Convert some debugging printfs to trace calls in pcnet.c., Michael Tokarev, 2015/02/10
- [Qemu-devel] [PULL 07/46] vl: Fix bogus error message for implied mon ID clashing, Michael Tokarev, 2015/02/10
- [Qemu-devel] [PULL 26/46] util/uri: uri_new() can't fail, drop dead error handling, Michael Tokarev, 2015/02/10
- [Qemu-devel] [PULL 38/46] disas/sh4: Fix warning caused by missing 'static' attribute, Michael Tokarev, 2015/02/10