[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/2] vga: Expose framebuffer byteorder as a QOM
From: |
David Gibson |
Subject: |
Re: [Qemu-devel] [PATCH 1/2] vga: Expose framebuffer byteorder as a QOM property |
Date: |
Tue, 10 Feb 2015 21:58:09 +1100 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Tue, Feb 10, 2015 at 10:19:58AM +0100, Gerd Hoffmann wrote:
> On Di, 2015-02-10 at 15:36 +1100, David Gibson wrote:
> > The VGA device model now supports having the framebuffer in either endian,
> > and can be switched between these by the guest via a register in the qext
> > region.
> >
> > However, in some cases (e.g. LE OS on the pseries machine) we have
> > existing guest that don't know about the endian switch register, but other
> > parts of the qemu code have better information to set a default endianness
> > than the VGA code does of itself.
> >
> > In order to allow them to set a correct default endianness in these cases,
> > without breaking abstraction walls, this patch exposes the VGA framebuffer
> > endianness via a writable QOM property.
> >
> > Signed-off-by: David Gibson <address@hidden>
> >
> > prop fixup
>
> squash leftover?
Oops, yes.
> Otherwise:
>
> Reviewed-by: Gerd Hoffmann <address@hidden>
>
> (assuming this little series gets in via ppc tree).
>
> cheers,
> Gerd
>
>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
pgpKd2nBVEQri.pgp
Description: PGP signature