[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH RFC v5 2/5] qemu-iotests: run qemu with -nodefau

From: Max Reitz
Subject: Re: [Qemu-devel] [PATCH RFC v5 2/5] qemu-iotests: run qemu with -nodefaults and fix 067, 071, 087
Date: Tue, 10 Feb 2015 15:56:13 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0

On 2015-02-10 at 02:59, Xiao Guang Chen wrote:
This patch fixes an io test suite issue that was introduced with the
commit c88930a6866e74953e931ae749781e98e486e5c8 'qemu-char: Permit only
a single "stdio" character device'. The option supresses the creation of
default devices such as the floopy and cdrom. Output files for test case
067, 071 and 087 need to be updated to accommodate this change.
Use virtio-blk instead of virtio-blk-pci as the device driver for test case
067. For virtio-blk-pci is the same with virtio-blk as device driver but
other platform such as s390 may not recognize the virtio-blk-pci.

Reviewed-by: Michael Mueller <address@hidden>
Signed-off-by: Xiao Guang Chen <address@hidden>
  tests/qemu-iotests/067           |   8 +-
  tests/qemu-iotests/067.out       | 266 +--------------------------------------
  tests/qemu-iotests/071.out       |   4 -
  tests/qemu-iotests/087.out       |  12 --
  tests/qemu-iotests/common        |   1 +
  tests/qemu-iotests/common.config |   2 +-
  tests/qemu-iotests/common.qemu   |   2 +-
  7 files changed, 8 insertions(+), 287 deletions(-)

I'm sorry I didn't notice earlier, but test 081 needs the same treatment. Apart from this, this patch looks good to me, though.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]