[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/9] monitor: Clean up around monitor_handle_fd_
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 2/9] monitor: Clean up around monitor_handle_fd_param() |
Date: |
Tue, 10 Feb 2015 14:09:33 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 |
On 02/10/2015 09:34 AM, Markus Armbruster wrote:
> monitor_handle_fd_param() is a wrapper around
> monitor_handle_fd_param2() that feeds errors to qerror_report_err()
> instead of returning them. qerror_report_err() is inappropriate in
> many contexts. monitor_handle_fd_param() looks simpler than
> monitor_handle_fd_param2(), which tempts use. Remove the temptation:
> drop the wrapper and open-code the (trivial) error handling instead.
>
> Replace the open-coded qerror_report_err() by error_report_err() in
> places that already use error_report(). Turns out that's everywhere.
>
> While there, rename monitor_handle_fd_param2() to monitor_fd_param().
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> hw/i386/kvm/pci-assign.c | 5 ++---
> hw/scsi/vhost-scsi.c | 2 +-
> include/monitor/monitor.h | 3 +--
> monitor.c | 15 +--------------
> net/socket.c | 4 +++-
> net/tap.c | 11 ++++++++---
> 6 files changed, 16 insertions(+), 24 deletions(-)
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 0/9] Clean up around error_get_pretty(), qerror_report_err(), Markus Armbruster, 2015/02/10
- [Qemu-devel] [PATCH 3/9] monitor: Avoid qerror_report_err() outside QMP command handlers, Markus Armbruster, 2015/02/10
- [Qemu-devel] [PATCH 6/9] tpm: Avoid qerror_report_err() outside QMP command handlers, Markus Armbruster, 2015/02/10
- [Qemu-devel] [PATCH 2/9] monitor: Clean up around monitor_handle_fd_param(), Markus Armbruster, 2015/02/10
- Re: [Qemu-devel] [PATCH 2/9] monitor: Clean up around monitor_handle_fd_param(),
Eric Blake <=
- [Qemu-devel] [PATCH 1/9] error: New convenience function error_report_err(), Markus Armbruster, 2015/02/10
- Re: [Qemu-devel] [PATCH 1/9] error: New convenience function error_report_err(), Markus Armbruster, 2015/02/11
- Re: [Qemu-devel] [PATCH 1/9] error: New convenience function error_report_err(), Eric Blake, 2015/02/10
[Qemu-devel] [PATCH 7/9] vl: Avoid qerror_report_err() outside QMP command handlers, Markus Armbruster, 2015/02/10