[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v12 03/17] block: Introduce bdrv_dirty_bitmap_gr

From: John Snow
Subject: Re: [Qemu-devel] [PATCH v12 03/17] block: Introduce bdrv_dirty_bitmap_granularity()
Date: Tue, 10 Feb 2015 17:15:45 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0

On 02/10/2015 05:13 PM, Max Reitz wrote:
On 2015-02-09 at 20:35, John Snow wrote:
This returns the granularity (in bytes) of dirty bitmap,
which matches the QMP interface and the existing query

Small adjustments are made to ensure that granularity-- in bytes--
is handled consistently as a uint64_t throughout the code.

Just asking whether you want to adjust the following, too: "int
granularity" in mirror_free_init() (the granularity is stored as an 64
bit integer, but the value is limited by qmp_drive_mirror() to stay
between 512 and 64M, and is defined to be a uint32_t by

It's fine from my perspective, so my R-b stands, but it looked like it
might conflict with "is handled consistently". :-)


Signed-off-by: John Snow <address@hidden>
  block.c               | 17 +++++++++++------
  include/block/block.h |  3 ++-
  2 files changed, 13 insertions(+), 7 deletions(-)

I'll take a look! Every time I change a type I have to change ten more. It is a ceaseless game of whackamole.

When I inevitably need to change the QMP parameter name again, I'll fix this while I'm at it.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]