[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v12 16/17] blkdebug: fix "once" rule

From: John Snow
Subject: Re: [Qemu-devel] [PATCH v12 16/17] blkdebug: fix "once" rule
Date: Wed, 11 Feb 2015 17:04:42 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0

On 02/11/2015 04:50 PM, Max Reitz wrote:
On 2015-02-09 at 20:35, John Snow wrote:
   The blkdebug scripts are currently engineered so that when a debug
event occurs, a prefilter browses a master list of parsed rules for a
certain event and adds them to an "active list" of rules to be used for
the forthcoming action, provided the events and state numbers match.

   Then, once the request is received, the last active rule is used to
inject an error if certain parameters match.

   This active list is cleared every time the prefilter injects a new
rule for the first time during a debug event.

   The "once" rule currently causes the error injection, if it is
triggered, to only clear the active list. This is insufficient for
preventing future injections of the same rule.

   This patch /deletes/ the rule from the list that the prefilter
browses, so it is gone for good. In V2, we remove only the rule of
interest from the active list instead of allowing the "once" rule to
clear the entire list of active rules.

   This affects iotests 026. Several ENOSPC tests that used "once" can
be seen to have output that shows multiple failure messages. After
this patch, the error messages tend to be smaller and less severe, but
the injection can still be seen to be working. I have patched the
expected output to expect the smaller error messages.

Signed-off-by: John Snow <address@hidden>
  block/blkdebug.c           |  6 ++++--
  tests/qemu-iotests/026.out | 24 ++++--------------------
  2 files changed, 8 insertions(+), 22 deletions(-)

Well, I think this shouldn't be part of this series, but you can find my
R-b here:


I will need to do a version bump to address patches 7-9, fix error messages, and other house-cleaning issues.

I can just put in the cover letter that this series *depends* on that other patch.

Otherwise, this series can be merged up to this patch before it's actually needed and it won't have any ill effect.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]