[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH] sheepdog: Fix misleading error messages in sd_snaps

From: Markus Armbruster
Subject: [Qemu-devel] [PATCH] sheepdog: Fix misleading error messages in sd_snapshot_create()
Date: Thu, 12 Feb 2015 14:49:50 +0100

If do_sd_create() fails, it first reports the error returned, then
reports a another one with strerror(errno).  errno is meaningless at
that point.

Report just one error combining the valid information from both

Reported-by: Eric Blake <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>
Applies on top of my "[PATCH v2 00/10] Clean up around
error_get_pretty(), qerror_report_err()", but rebasing to master would
be trivial.

 block/sheepdog.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/block/sheepdog.c b/block/sheepdog.c
index 6a4a3bd..0e8c712 100644
--- a/block/sheepdog.c
+++ b/block/sheepdog.c
@@ -2225,9 +2225,8 @@ static int sd_snapshot_create(BlockDriverState *bs, 
QEMUSnapshotInfo *sn_info)
     ret = do_sd_create(s, &new_vid, 1, &local_err);
     if (ret < 0) {
-        error_report_err(local_err);
-        error_report("failed to create inode for snapshot. %s",
-                     strerror(errno));
+        error_report("failed to create inode for snapshot: %s",
+                     error_get_pretty(local_err));
         goto cleanup;

reply via email to

[Prev in Thread] Current Thread [Next in Thread]