qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 2/3] numa: Reject configuration if CPU appear


From: Eduardo Habkost
Subject: Re: [Qemu-devel] [PATCH v2 2/3] numa: Reject configuration if CPU appears on multiple nodes
Date: Thu, 12 Feb 2015 15:54:06 -0200
User-agent: Mutt/1.5.23 (2014-03-12)

On Thu, Feb 12, 2015 at 05:01:54PM +0100, Igor Mammedov wrote:
> On Thu, 12 Feb 2015 13:24:26 -0200
> Eduardo Habkost <address@hidden> wrote:
> 
> > On Thu, Feb 12, 2015 at 04:01:49PM +0100, Igor Mammedov wrote:
[...]
> > > > +    DECLARE_BITMAP(present_cpus, MAX_CPUMASK_BITS);
> > > naming is a bit confusing, it's not really present CPUs but
> > > more like possible_cpus
> > 
> > I meant "present in the NUMA configuration". "Possible" wouldn't
> > describe it IMO, as it is just tracking the CPUs seen in the config. I
> > will rename it to "seen_cpus" in the next version.
> or maybe numa_cpus

We're already inside numa.c in a function called validate_numa_cpus(). I
believe a "numa_" prefix would be redundant.

(I just sent v3 of the series using seen_cpus, anyway)

-- 
Eduardo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]