[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/5] target-tile: Firstly add to qemu with minim
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH 1/5] target-tile: Firstly add to qemu with minimized features |
Date: |
Sat, 14 Feb 2015 00:26:59 +0000 |
On 13 February 2015 at 23:50, Chen Gang S <address@hidden> wrote:
>
> On 2/13/15 05:15, Chen Gang S wrote:
>> It almost likes a template for adding an architecture target.
>>
>> Signed-off-by: Chen Gang <address@hidden>
>> ---
>> configure | 7 ++
>> default-configs/tilegx-linux-user.mak | 1 +
>> target-tile/Makefile.objs | 1 +
>> target-tile/cpu-qom.h | 72 +++++++++++++++
>> target-tile/cpu.c | 159
>> ++++++++++++++++++++++++++++++++++
>> target-tile/cpu.h | 84 ++++++++++++++++++
>> target-tile/helper.h | 0
>> target-tile/translate.c | 54 ++++++++++++
>> 8 files changed, 378 insertions(+)
>> create mode 100644 default-configs/tilegx-linux-user.mak
>> create mode 100644 target-tile/Makefile.objs
>> create mode 100644 target-tile/cpu-qom.h
>> create mode 100644 target-tile/cpu.c
>> create mode 100644 target-tile/cpu.h
>> create mode 100644 target-tile/helper.h
>> create mode 100644 target-tile/translate.c
>>
>> diff --git a/configure b/configure
>> index 7ba4bcb..ffb4d56 100755
>> --- a/configure
>> +++ b/configure
>> @@ -5191,6 +5191,9 @@ case "$target_name" in
>> s390x)
>> gdb_xml_files="s390x-core64.xml s390-acr.xml s390-fpr.xml"
>> ;;
>> + tilegx)
>> + TARGET_ARCH=tile
>> + ;;
>
> Oh, it needs to use "TARGET_ARCH=tilegx" instead of "TARGET_ARCH=tile",
> or can not put "CONFIG_TILE_DIS=y" to config-all-disas.mak, below (when
> I am adding "disas/tilegx.c", I meet it).
You need to make up your mind about what your architecture
is called: is it "tile" or "tilegx"? Be consistent...
>
>> unicore32)
>> ;;
>> xtensa|xtensaeb)
>> @@ -5363,6 +5366,10 @@ for i in $ARCH $TARGET_BASE_ARCH ; do
>> echo "CONFIG_SPARC_DIS=y" >> $config_target_mak
>> echo "CONFIG_SPARC_DIS=y" >> config-all-disas.mak
>> ;;
>> + tilegx*)
>> + echo "CONFIG_TILE_DIS=y" >> $config_target_mak
>> + echo "CONFIG_TILE_DIS=y" >> config-all-disas.mak
>> + ;;
You should only add this bit to configure in the patchset
where you add a Tile disassembler.
-- PMM
- [Qemu-devel] [PATCH 0/5] tile: Can load elf64 tilegx binary successfully for linux-user, Chen Gang S, 2015/02/12
- [Qemu-devel] [PATCH 1/5] target-tile: Firstly add to qemu with minimized features, Chen Gang S, 2015/02/12
- Re: [Qemu-devel] [PATCH 1/5] target-tile: Firstly add to qemu with minimized features, Chen Gang S, 2015/02/13
- Re: [Qemu-devel] [PATCH 1/5] target-tile: Firstly add to qemu with minimized features, Chen Gang S, 2015/02/13
- Re: [Qemu-devel] [PATCH 1/5] target-tile: Firstly add to qemu with minimized features, Peter Maydell, 2015/02/13
- Re: [Qemu-devel] [PATCH 1/5] target-tile: Firstly add to qemu with minimized features, Chris Metcalf, 2015/02/13
- Re: [Qemu-devel] [PATCH 1/5] target-tile: Firstly add to qemu with minimized features, Peter Maydell, 2015/02/14
- Re: [Qemu-devel] [PATCH 1/5] target-tile: Firstly add to qemu with minimized features, Chen Gang S, 2015/02/14
- Re: [Qemu-devel] [PATCH 1/5] target-tile: Firstly add to qemu with minimized features, Chen Gang S, 2015/02/15
- Re: [Qemu-devel] [PATCH 1/5] target-tile: Firstly add to qemu with minimized features, Chen Gang S, 2015/02/16
- Re: [Qemu-devel] [PATCH 1/5] target-tile: Firstly add to qemu with minimized features, Chris Metcalf, 2015/02/16