[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [RFC PATCH v8 08/21] cpu: replay instructions sequence

From: Pavel Dovgaluk
Subject: Re: [Qemu-devel] [RFC PATCH v8 08/21] cpu: replay instructions sequence
Date: Mon, 16 Feb 2015 16:27:24 +0300

> From: Paolo Bonzini [mailto:address@hidden On Behalf Of Paolo Bonzini
> On 16/02/2015 13:26, Pavel Dovgaluk wrote:
> >>> > > I think in this case there are no events at all - just reading timers 
> >>> > > values
> >>> > > that were made while recording.
> >>> > > We have to replay these reads by waking iothread.
> >> >
> >> > I think the right place for this is in replay_read_next_clock then.
> > It doesn't fit. Log file is not read until all instructions are executed.
> > And the next read from the file should be performed by iothread which should
> > be notified and waked up.
> I still don't understand.  If you're getting EXCP_INTERRUPT it means:
> 1) that cpu_signal was called

No, it isn't. That is the branch when icount is expired.
And when it is expired in replay mode we have to wake up iothread,
because nobody will care about this.

> 2) in turn this means that qemu_cpu_kick was called
> 3) in turn this means that the iothread is trying to run via
> qemu_mutex_lock_iothread (the iothread_requesting_mutex stuff).  So why
> do you need an explicit qemu_notify_event?

Pavel Dovgalyuk

reply via email to

[Prev in Thread] Current Thread [Next in Thread]