[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v13 02/17] qmp: Ensure consistent granularity ty

From: Max Reitz
Subject: Re: [Qemu-devel] [PATCH v13 02/17] qmp: Ensure consistent granularity type
Date: Mon, 16 Feb 2015 14:49:50 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0

On 2015-02-13 at 17:08, John Snow wrote:
We treat this field with a variety of different types everywhere
in the code. Now it's just uint32_t.

Signed-off-by: John Snow <address@hidden>
  block.c                   | 11 ++++++-----
  block/mirror.c            |  4 ++--
  include/block/block.h     |  2 +-
  include/block/block_int.h |  2 +-
  qapi/block-core.json      |  2 +-
  5 files changed, 11 insertions(+), 10 deletions(-)

Considering you called this series the "$MY_NAME Fixup issue", I'm assuming this patch is the response to something I said, maybe that Coverity might complain about one right-shift of a 64 bit value with the result stored in a 32 bit integer. If so, that would have been preventable by assert((x >> 9) <= INT_MAX), so it's not that you would have to force everything to be 32 bits wide.

Anyway, I'm fine with either 32 or 64 bits (2 GB maximum granularity should be good for now):

Reviewed-by: Max Reitz <address@hidden>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]