[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 1/2] vga: abort instead of shrinking memory

From: Gerd Hoffmann
Subject: Re: [Qemu-devel] [PATCH 1/2] vga: abort instead of shrinking memory
Date: Tue, 17 Feb 2015 09:00:49 +0100

On Mo, 2015-02-16 at 22:23 +0100, Radim Krčmář wrote:
> Automatic shrinking of vram_size leads to a segfault, because other
> variables depend on being smaller and don't get shrinked.

--verbose please.  Which other variables?

> Implications of shrinking would make the code needlessly complicated;
> assert instead.

assert isn't an option.  vram_size_mb may come from the user (via vga
device properties), so we need a friendly error message here.

Also the loop you are removing makes sure vram_size is a power of two,
removing that is not correct too.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]