Re: [Qemu-devel] [RFC PATCH v9 06/23] replay: introduce icount event

[Paolo Bonzini]

On 18/02/2015 12:56, Pavel Dovgalyuk wrote:
> +    /* nothing to skip - not all instructions used */
> +    if (replay_state.instructions_count != 0
> +        && replay_has_unread_data) {
> +        return stop_event == EVENT_INSTRUCTION;

Same here, please assert that replay_data_kind == EVENT_INSTRUCTION.
Assertions communicate invariants, and thus help the person reading the
code.

Paolo

> +    }