[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] migration: Avoid qerror_report_err() outside QM
From: |
Juan Quintela |
Subject: |
Re: [Qemu-devel] [PATCH] migration: Avoid qerror_report_err() outside QMP command handlers |
Date: |
Thu, 19 Feb 2015 00:09:31 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.4 (gnu/linux) |
Markus Armbruster <address@hidden> wrote:
> qerror_report_err() is a transitional interface to help with
> converting existing monitor commands to QMP. It should not be used
> elsewhere. Replace by error_report_err() in
> process_incoming_migration_co().
I trust you & eric
Included, thanks.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> Based on
> [PATCH v2 00/10] Clean up around error_get_pretty(), qerror_report_err()
>
> migration/migration.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/migration/migration.c b/migration/migration.c
> index b3adbc6..6a5e3f9 100644
> --- a/migration/migration.c
> +++ b/migration/migration.c
> @@ -106,8 +106,7 @@ static void process_incoming_migration_co(void *opaque)
> /* Make sure all file formats flush their mutable metadata */
> bdrv_invalidate_cache_all(&local_err);
> if (local_err) {
> - qerror_report_err(local_err);
> - error_free(local_err);
> + error_report_err(local_err);
> exit(EXIT_FAILURE);
> }