[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/2] target-mips: add missing MSA and correct FP
|
From: |
Maciej W. Rozycki |
|
Subject: |
Re: [Qemu-devel] [PATCH 2/2] target-mips: add missing MSA and correct FP in VMState |
|
Date: |
Fri, 20 Feb 2015 13:12:27 +0000 (GMT) |
|
User-agent: |
Alpine 2.11 (LFD 23 2013-08-11) |
On Thu, 19 Feb 2015, Leon Alrae wrote:
> > Surely these fp_status fields are simply implementation of the architectural
> > CSR registers?
> >
> > IMO you shouldn't store things related to TCG state, but always how the
> > architecture represents it. That way you're free to change the TCG
> > implementation without breaking save/restore.
>
> Good point. Saving fp_status and msa_fp_status doesn't seem to be needed
> at all as they can be restored from FCSR and MSACSR respectively.
Agreed. Richard, thanks for the suggestion!
Maciej