[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH v2 04/15] cpu-model/s390: Introduce S390 CPU
From: |
Michael Mueller |
Subject: |
Re: [Qemu-devel] [RFC PATCH v2 04/15] cpu-model/s390: Introduce S390 CPU models |
Date: |
Fri, 20 Feb 2015 16:49:44 +0100 |
On Fri, 20 Feb 2015 16:22:20 +0100
Alexander Graf <address@hidden> wrote:
> >>
> >> Just make this uint64_t fac_list[2]. That way we don't have to track any
> >> messy allocations.
> >
> > It will be something like "uint64_t
> > fac_list[S390_CPU_FAC_LIST_SIZE_UINT64]" and in total 2KB
> > not just 16 bytes but I will change it.
>
> Why? Do we actually need that many? This is a qemu internal struct.
How do you know that 2 is a good size?
I want to have this independent from a future machine of the z/Arch. The kernel
stores the full
facility set, KVM does and there is no good reason for QEMU not to do. If other
accelerators
decide to just implement 64 or 128 bits of facilities that's ok...
Michael
- [Qemu-devel] [RFC PATCH v2 00/15] QEMU: s390: cpu model implementation, Michael Mueller, 2015/02/17
- [Qemu-devel] [RFC PATCH v2 03/15] cpu-model: Introduce stub routine cpu_desc_avail, Michael Mueller, 2015/02/17
- [Qemu-devel] [RFC PATCH v2 07/15] cpu-model/s390: Add cpu model alias definition routines, Michael Mueller, 2015/02/17
- [Qemu-devel] [RFC PATCH v2 04/15] cpu-model/s390: Introduce S390 CPU models, Michael Mueller, 2015/02/17
- Re: [Qemu-devel] [RFC PATCH v2 04/15] cpu-model/s390: Introduce S390 CPU models, Alexander Graf, 2015/02/20
- Re: [Qemu-devel] [RFC PATCH v2 04/15] cpu-model/s390: Introduce S390 CPU models, Michael Mueller, 2015/02/20
- Re: [Qemu-devel] [RFC PATCH v2 04/15] cpu-model/s390: Introduce S390 CPU models, Alexander Graf, 2015/02/20
- Re: [Qemu-devel] [RFC PATCH v2 04/15] cpu-model/s390: Introduce S390 CPU models,
Michael Mueller <=
- Re: [Qemu-devel] [RFC PATCH v2 04/15] cpu-model/s390: Introduce S390 CPU models, Alexander Graf, 2015/02/20
- Re: [Qemu-devel] [RFC PATCH v2 04/15] cpu-model/s390: Introduce S390 CPU models, Michael Mueller, 2015/02/20
- Re: [Qemu-devel] [RFC PATCH v2 04/15] cpu-model/s390: Introduce S390 CPU models, Alexander Graf, 2015/02/20
- Re: [Qemu-devel] [RFC PATCH v2 04/15] cpu-model/s390: Introduce S390 CPU models, Michael Mueller, 2015/02/20
- Re: [Qemu-devel] [RFC PATCH v2 04/15] cpu-model/s390: Introduce S390 CPU models, Alexander Graf, 2015/02/20
- Re: [Qemu-devel] [RFC PATCH v2 04/15] cpu-model/s390: Introduce S390 CPU models, Christian Borntraeger, 2015/02/23
- Re: [Qemu-devel] [RFC PATCH v2 04/15] cpu-model/s390: Introduce S390 CPU models, Christian Borntraeger, 2015/02/23
Re: [Qemu-devel] [RFC PATCH v2 04/15] cpu-model/s390: Introduce S390 CPU models, Alexander Graf, 2015/02/20
[Qemu-devel] [RFC PATCH v2 11/15] cpu-model/s390: Add QMP command query-cpu-model, Michael Mueller, 2015/02/17