[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH v2 09/15] cpu-model/s390: Add KVM VM attribu
From: |
Alexander Graf |
Subject: |
Re: [Qemu-devel] [RFC PATCH v2 09/15] cpu-model/s390: Add KVM VM attribute interface routines |
Date: |
Fri, 20 Feb 2015 17:59:14 +0100 |
User-agent: |
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 |
On 20.02.15 16:18, Michael Mueller wrote:
> On Fri, 20 Feb 2015 14:59:20 +0100
> Alexander Graf <address@hidden> wrote:
>
>>> +typedef struct S390ProcessorProps {
>>> + uint64_t cpuid;
>>> + uint16_t ibc;
>>> + uint8_t pad[6];
>>> + uint64_t fac_list[S390_ARCH_FAC_LIST_SIZE_UINT64];
>>> +} S390ProcessorProps;
>>> +
>>> +typedef struct S390MachineProps {
>>> + uint64_t cpuid;
>>> + uint32_t ibc_range;
>>> + uint8_t pad[4];
>>> + uint64_t fac_list_mask[S390_ARCH_FAC_LIST_SIZE_UINT64];
>>> + uint64_t fac_list[S390_ARCH_FAC_LIST_SIZE_UINT64];
>>> +} S390MachineProps;
>>
>> What are those structs there for? To convert between a kvm facing
>> interface to an internal interface?
>
> Yes, that's their current use, but if the interface structs:
>
> +struct kvm_s390_vm_cpu_processor {
> + __u64 cpuid;
> + __u16 ibc;
> + __u8 pad[6];
> + __u64 fac_list[256];
> +};
> +
> +/* kvm S390 machine related attributes are r/o */
> +#define KVM_S390_VM_CPU_MACHINE 1
> +struct kvm_s390_vm_cpu_machine {
> + __u64 cpuid;
> + __u32 ibc_range;
> + __u8 pad[4];
> + __u64 fac_mask[256];
> + __u64 fac_list[256];
> +};
>
> are visible here, I'll reuse them... But stop, that will not work in the
> --disable-kvm case... I need them!
I meant it the other way around - do KVM specific patching of the cpu
types from kvm.c.
But please give a nutshell explanation on what exactly you're patching
at all here.
Alex
- Re: [Qemu-devel] [RFC PATCH v2 04/15] cpu-model/s390: Introduce S390 CPU models, (continued)
Re: [Qemu-devel] [RFC PATCH v2 04/15] cpu-model/s390: Introduce S390 CPU models, Alexander Graf, 2015/02/20
[Qemu-devel] [RFC PATCH v2 11/15] cpu-model/s390: Add QMP command query-cpu-model, Michael Mueller, 2015/02/17
[Qemu-devel] [RFC PATCH v2 09/15] cpu-model/s390: Add KVM VM attribute interface routines, Michael Mueller, 2015/02/17
[Qemu-devel] [RFC PATCH v2 15/15] cpu-model/s390: Enable S390 cpu model, Michael Mueller, 2015/02/17
[Qemu-devel] [RFC PATCH v2 06/15] cpu-model/s390: Define cpu model specific facility lists, Michael Mueller, 2015/02/17
[Qemu-devel] [RFC PATCH v2 08/15] cpu-model/s390: Update linux-headers/asm-s390/kvm.h, Michael Mueller, 2015/02/17
[Qemu-devel] [RFC PATCH v2 01/15] cpu-model: Introduce probe mode for machine none, Michael Mueller, 2015/02/17
[Qemu-devel] [RFC PATCH v2 12/15] cpu-model/s390: Extend QMP command query-cpu-definitions, Michael Mueller, 2015/02/17
[Qemu-devel] [RFC PATCH v2 05/15] cpu-model/s390: Introduce S390 CPU facilities, Michael Mueller, 2015/02/17
[Qemu-devel] [RFC PATCH v2 14/15] cpu-model/s390: Add cpu model selection routine, Michael Mueller, 2015/02/17