[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3] Makefile.target: set icon for binary file on

From: Programmingkid
Subject: Re: [Qemu-devel] [PATCH v3] Makefile.target: set icon for binary file on Mac OS X
Date: Fri, 20 Feb 2015 12:06:15 -0500

On Feb 20, 2015, at 6:41 AM, Paolo Bonzini wrote:

On 19/02/2015 21:51, Programmingkid wrote:
This patch sets the icon for the QEMU binary on Mac OS X.

Signed-off-by: John Arbuckle <address@hidden>

Added conditional code to make the icon setting happen only on Mac OS X. 

Applied, but I'd like a "Tested-by" from Peter Maydell or another OS X
user.  Also, before sending a pull request I'll also check on my
in-laws' Mac (which I found has gcc installed) whether it also has Rez
and SetFile.


I did some looking myself and found out that the Rez and SetFile command are missing on Mac OS 10.4 (and probably below). They are available on Mac OS 10.5 and Mac OS 10.6. Since this feature isn't important, I can add conditional code that would check to see if the Rez and SetFile commands are available on the computer before using them. The thing is Mac OS 10.4 and under appear to be no longer supported by QEMU, so this might not be a problem. 

reply via email to

[Prev in Thread] Current Thread [Next in Thread]