Re: [Qemu-devel] [PATCH 10/11] target-arm: Implement fccmp branchless

[Laurent Desnogues]

Hi Richard,

On Fri, Feb 20, 2015 at 4:53 PM, Richard Henderson <address@hidden> wrote:
> On 02/20/2015 05:57 AM, Laurent Desnogues wrote:
>> The problem with this approach is that you'll always call the FP
>> compare which might result in FP flags corruption.
>>
>> The ARMv8 manual clearly states that the FP compare should only be
>> called if the condition holds.
>
> Ah, I hadn't considered that.  Consider this patch dropped.

With this patch removed, all the FP tests pass as on master.

Thanks,

Laurent

> Thanks,
>
>
> r~