[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [RFC PATCH 12/14] Add disk buffer for block replication

From: Max Reitz
Subject: Re: [Qemu-devel] [RFC PATCH 12/14] Add disk buffer for block replication
Date: Mon, 23 Feb 2015 17:27:45 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0

On 2015-02-11 at 22:07, Wen Congyang wrote:
Signed-off-by: Wen Congyang <address@hidden>
Signed-off-by: zhanghailiang <address@hidden>
Signed-off-by: Gonglei <address@hidden>
  block/Makefile.objs    |   1 +
  block/blkcolo-buffer.c | 324 +++++++++++++++++++++++++++++++++++++++++++++++++
  block/blkcolo.h        |  35 ++++++
  3 files changed, 360 insertions(+)
  create mode 100644 block/blkcolo-buffer.c
  create mode 100644 block/blkcolo.h

In general: Can you please add some prefix to the non-static functions, like colo_*?

As for the design questions regarding this block driver, I should probably leave that to Fam and John (because they seemed to have an idea how to approach the issue at hand using a different implementation, based on functionality that's already (or close to become) part of qemu).

Therefore, I'm hesitating to review this patch (and the following ones) until you've reached a conclusion on how to proceed.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]