Re: [Qemu-devel] [PATCH 06/10] spapr_iommu: Add separate trace points for PCI DMA operations

[David Gibson]

On Mon, Feb 23, 2015 at 07:33:56PM +1100, Alexey Kardashevskiy wrote:
> This is to reduce VIO noise while debugging PCI DMA.
> 
> Signed-off-by: Alexey Kardashevskiy <address@hidden>

So, in terms of mechanical correctness:

Reviewed-by: David Gibson <address@hidden>

I see the rationale, but the idea of conditional tracepoints seems a
bit icky to me.  Don't know if the trace infrastructure people would
have any opinion on this.

-- 
David Gibson                    | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
                                | _way_ _around_!
http://www.ozlabs.org/~dgibson

pgpeQX_CEKxq1.pgp
Description: PGP signature