[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 05/10] leon3: Replace unchecked qdev_init() by qdev_i
From: |
Andreas Färber |
Subject: |
[Qemu-devel] [PULL 05/10] leon3: Replace unchecked qdev_init() by qdev_init_nofail() |
Date: |
Tue, 24 Feb 2015 14:58:25 +0100 |
From: Markus Armbruster <address@hidden>
grlib_irqmp_create(), grlib_gptimer_create() and
grlib_apbuart_create() are helpers to create and realize GRLIB
devices. Their only caller leon3_generic_hw_init() doesn't check for
failure. Only the first can actually fail, and only when the caller
fails to set up a pointer property, which is a programming error.
Replace qdev_init() by qdev_init_nofail().
Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Fabien Chouteau <address@hidden>
Signed-off-by: Andreas Färber <address@hidden>
---
include/hw/sparc/grlib.h | 12 +++---------
1 file changed, 3 insertions(+), 9 deletions(-)
diff --git a/include/hw/sparc/grlib.h b/include/hw/sparc/grlib.h
index 470ce72..9a0db7b 100644
--- a/include/hw/sparc/grlib.h
+++ b/include/hw/sparc/grlib.h
@@ -55,9 +55,7 @@ DeviceState *grlib_irqmp_create(hwaddr base,
qdev_prop_set_ptr(dev, "set_pil_in", set_pil_in);
qdev_prop_set_ptr(dev, "set_pil_in_opaque", env);
- if (qdev_init(dev)) {
- return NULL;
- }
+ qdev_init_nofail(dev);
env->irq_manager = dev;
@@ -87,9 +85,7 @@ DeviceState *grlib_gptimer_create(hwaddr base,
qdev_prop_set_uint32(dev, "frequency", freq);
qdev_prop_set_uint32(dev, "irq-line", base_irq);
- if (qdev_init(dev)) {
- return NULL;
- }
+ qdev_init_nofail(dev);
sysbus_mmio_map(SYS_BUS_DEVICE(dev), 0, base);
@@ -112,9 +108,7 @@ DeviceState *grlib_apbuart_create(hwaddr base,
dev = qdev_create(NULL, "grlib,apbuart");
qdev_prop_set_chr(dev, "chrdev", serial);
- if (qdev_init(dev)) {
- return NULL;
- }
+ qdev_init_nofail(dev);
sysbus_mmio_map(SYS_BUS_DEVICE(dev), 0, base);
--
2.1.4
- [Qemu-devel] [PULL 00/10] QOM devices patch queue 2015-02-24, Andreas Färber, 2015/02/24
- [Qemu-devel] [PULL 08/10] serial: serial_hds_isa_init() shouldn't fail, Andreas Färber, 2015/02/24
- [Qemu-devel] [PULL 07/10] serial: Factor out common serial_hds_isa_init(), Andreas Färber, 2015/02/24
- [Qemu-devel] [PULL 01/10] qdev: Avoid type assertion in qdev_build_hotpluggable_device_list(), Andreas Färber, 2015/02/24
- [Qemu-devel] [PULL 02/10] qom: Fix typo, 'my_class_init' -> 'derived_class_init', Andreas Färber, 2015/02/24
- [Qemu-devel] [PULL 05/10] leon3: Replace unchecked qdev_init() by qdev_init_nofail(),
Andreas Färber <=
- [Qemu-devel] [PULL 09/10] parallel: Factor out common parallel_hds_isa_init(), Andreas Färber, 2015/02/24
- [Qemu-devel] [PULL 06/10] etsec: Replace qdev_init() by qdev_init_nofail(), Andreas Färber, 2015/02/24
- [Qemu-devel] [PULL 04/10] ide/isa: Replace unchecked qdev_init() by qdev_init_nofail(), Andreas Färber, 2015/02/24
- [Qemu-devel] [PULL 03/10] qdev: Improve qdev_init_nofail()'s error reporting, Andreas Färber, 2015/02/24
- [Qemu-devel] [PULL 10/10] parallel: parallel_hds_isa_init() shouldn't fail, Andreas Färber, 2015/02/24
- Re: [Qemu-devel] [PULL 00/10] QOM devices patch queue 2015-02-24, Mark Cave-Ayland, 2015/02/24