qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] target-tilegx: Execute _start and reach to __li


From: Chris Metcalf
Subject: Re: [Qemu-devel] [PATCH] target-tilegx: Execute _start and reach to __libc_start_main successfully
Date: Tue, 24 Feb 2015 13:18:58 -0500
User-agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0

On 2/24/2015 12:25 PM, Chen Gang S wrote:
For me, if the raw integer is only used once, we needn't define a macro
for it (instead of, we can give a comment for it).

The advantage of names even in this case is that you can group all the
macro definitions in one place where they are easy to read and review.
Then later when you use them they are self-documenting.  And if you
are going to use opcode_tilegx.h anyway, you get the names "for free".

--
Chris Metcalf, EZChip Semiconductor
http://www.ezchip.com




reply via email to

[Prev in Thread] Current Thread [Next in Thread]