[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH 32/43] vt82c686: avoid out-of-bounds read

From: Michael Roth
Subject: [Qemu-devel] [PATCH 32/43] vt82c686: avoid out-of-bounds read
Date: Tue, 24 Feb 2015 15:48:07 -0600

From: Paolo Bonzini <address@hidden>

superio_ioport_readb can read the 256th element of the array.
Coverity reports an out-of-bounds write in superio_ioport_writeb,
but it does not show the corresponding out-of-bounds read
because it cannot prove that it can happen.  Fix the root
cause of the problem (zhanghailang's patch instead fixes
the logic in superio_ioport_writeb).

Signed-off-by: Paolo Bonzini <address@hidden>
Reviewed-by: zhanghailiang <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>
Cc: address@hidden
(cherry picked from commit 9feb8adeaa850d15b930c30f22c1ed2f2f695172)
Signed-off-by: Michael Roth <address@hidden>
 hw/isa/vt82c686.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/isa/vt82c686.c b/hw/isa/vt82c686.c
index e0c235c..a43e26d 100644
--- a/hw/isa/vt82c686.c
+++ b/hw/isa/vt82c686.c
@@ -36,7 +36,7 @@
 typedef struct SuperIOConfig
-    uint8_t config[0xff];
+    uint8_t config[0x100];
     uint8_t index;
     uint8_t data;
 } SuperIOConfig;

reply via email to

[Prev in Thread] Current Thread [Next in Thread]