[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH 37/43] vfio-pci: Fix missing unparent of dynamically

From: Michael Roth
Subject: [Qemu-devel] [PATCH 37/43] vfio-pci: Fix missing unparent of dynamically allocated MemoryRegion
Date: Tue, 24 Feb 2015 15:48:12 -0600

From: Alex Williamson <address@hidden>

Commit d8d95814609e added explicit object_unparent() calls for
dynamically allocated MemoryRegions.  The VFIOMSIXInfo structure also
contains such a MemoryRegion, covering the mmap'd region of a PCI BAR
above the MSI-X table.  This structure is freed as part of the class
exit function and therefore also needs an explicit object_unparent().
Failing to do this results in random segfaults due to fields within
the structure, often the class pointer, being reclaimed and corrupted
by the time object_finalize_child_property() is called for the object.

Signed-off-by: Alex Williamson <address@hidden>
Reviewed-by: Paolo Bonzini <address@hidden>
Cc: address@hidden # 2.2
(cherry picked from commit 3a4dbe6aa934370a92372528c1255ee1504965ee)
Signed-off-by: Michael Roth <address@hidden>
 hw/misc/vfio.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/hw/misc/vfio.c b/hw/misc/vfio.c
index fd318a1..7bff62c 100644
--- a/hw/misc/vfio.c
+++ b/hw/misc/vfio.c
@@ -4049,6 +4049,7 @@ static void vfio_put_device(VFIODevice *vdev)
     DPRINTF("vfio_put_device: close vdev->fd\n");
     if (vdev->msix) {
+        object_unparent(OBJECT(&vdev->msix->mmap_mem));
         vdev->msix = NULL;

reply via email to

[Prev in Thread] Current Thread [Next in Thread]