[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] sheepdog: fix confused return values
|
From: |
Liu Yuan |
|
Subject: |
Re: [Qemu-devel] [PATCH] sheepdog: fix confused return values |
|
Date: |
Wed, 25 Feb 2015 09:39:53 +0800 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Wed, Feb 18, 2015 at 09:35:07AM +0100, Markus Armbruster wrote:
> Liu Yuan <address@hidden> writes:
>
> > From: Liu Yuan <address@hidden>
> >
> > These functions mix up -1 and -errno in return values and would might cause
> > trouble error handling in the call chain.
> >
> > This patch let them return -errno and add some comments.
> >
> > Reported-by: Markus Armbruster <address@hidden>
> > Signed-off-by: Liu Yuan <address@hidden>
>
> Did you review all functions returning negative errno, or just the two
> that caught my eye?
Umm, mostly the two you mentioned.
Yuan