[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 05/10] qga: introduce three guest memory block c

From: zhanghailiang
Subject: Re: [Qemu-devel] [PATCH 05/10] qga: introduce three guest memory block commmands with stubs
Date: Wed, 25 Feb 2015 10:51:59 +0800
User-agent: Mozilla/5.0 (Windows NT 6.1; rv:31.0) Gecko/20100101 Thunderbird/31.1.1

On 2015/2/17 23:26, Eric Blake wrote:
On 02/16/2015 08:14 PM, Michael Roth wrote:
From: zhanghailiang <address@hidden>

Introduce three new guest commands:
guest-get-memory-blocks, guest-set-memory-blocks, guest-get-memory-block-size.

Sorry for the late review, but I think guest-get-memory-block-size is
the wrong command to add.

+# @guest-get-memory-block-size:
+# Get the the size (in bytes) of a memory block in guest.
+# It is the unit of memory block online/offline operation (also called Logical
+# Memory Hotplug).
+# Returns: memory block size in bytes.
+# Since 2.3
+{ 'command': 'guest-get-memory-block-size',
+  'returns': 'int' }

Any QAPI command that returns a bare int instead of a dictionary is
non-extensible, and therefore of suspect design.  I think it would be
better to have:

{ 'command': 'guest-get-memory-block-info',
   'returns': { 'size': 'int' } }

to allow for future extension.

Good idea, and Michael Roth has changed it like that, thanks for you comments.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]