[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH RFC v3 17/27] COLO: Add new command parameter 'c

From: zhanghailiang
Subject: Re: [Qemu-devel] [PATCH RFC v3 17/27] COLO: Add new command parameter 'colo_nicname' 'colo_script' for net
Date: Wed, 25 Feb 2015 15:50:38 +0800
User-agent: Mozilla/5.0 (Windows NT 6.1; rv:31.0) Gecko/20100101 Thunderbird/31.1.1

On 2015/2/17 7:50, Eric Blake wrote:
On 02/11/2015 08:17 PM, zhanghailiang wrote:
The 'colo_nicname' should be assigned with network name,
for exmple, 'eth2'. It will be parameter of 'colo_script',


'colo_script' should be assigned with an scirpt path.

s/an scirpt/a script/

We parse these parameter in tap.

Script files are in general very hard to secure.  Libvirt marks any
domain that uses a script file for controlling networking as tainted,
because it cannot guarantee that the script did not do arbitrary
actions.  Can you come up with any better solution that does not require
a script file, such as having management software responsible for
passing in an already-opened fd?

Hmm, it is a good idea to discard the script, i will look into it later ;)

Signed-off-by: zhanghailiang <address@hidden>
Signed-off-by: Gao feng <address@hidden>
Signed-off-by: Li Zhijian <address@hidden>
  include/net/net.h |  4 ++++
  net/tap.c         | 27 ++++++++++++++++++++++++---
  qapi-schema.json  |  8 +++++++-
  qemu-options.hx   | 10 +++++++++-
  4 files changed, 44 insertions(+), 5 deletions(-)

+++ b/qapi-schema.json
@@ -2101,6 +2101,10 @@
  # @queues: #optional number of queues to be created for multiqueue capable tap
+# @colo_nicname: #optional the host physical nic for QEMU (Since 2.3)
+# @colo_script: #optional the script file which used by COLO (Since 2.3)

s/_/-/ in both parameter names, please.  Since they are optional, it
might be worth documenting what they default to when not present.

OK, will fix that. thanks.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]