[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 04/11] target-i386: Rename cpu_x86_init() to cpu_
|
From: |
Andreas Färber |
|
Subject: |
Re: [Qemu-devel] [PULL 04/11] target-i386: Rename cpu_x86_init() to cpu_x86_init_user() |
|
Date: |
Wed, 25 Feb 2015 23:06:55 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 |
Am 25.02.2015 um 20:58 schrieb Eduardo Habkost:
> The function is used only for CONFIG_USER, so make its purpose clear.
>
> Reviewed-by: Paolo Bonzini <address@hidden>
> Signed-off-by: Eduardo Habkost <address@hidden>
> ---
> target-i386/cpu.c | 2 +-
> target-i386/cpu.h | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
Please don't. I happily got all architectures aligned that it's at least
cpu_something_init, and it only happens to be user-only for x86. It is
rather the legacy function that was used in both system and user.
Regards,
Andreas
--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu,
Graham Norton; HRB 21284 (AG Nürnberg)
[Qemu-devel] [PULL 02/11] target-i386: Eliminate unnecessary get_cpuid_vendor() function, Eduardo Habkost, 2015/02/25
[Qemu-devel] [PULL 05/11] target-i386: Eliminate cpu_init() function, Eduardo Habkost, 2015/02/25
[Qemu-devel] [PULL 06/11] target-i386: Simplify error handling on cpu_x86_init_user(), Eduardo Habkost, 2015/02/25