[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PULL 08/21] rcu: run RCU callbacks under the BQL

From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PULL 08/21] rcu: run RCU callbacks under the BQL
Date: Thu, 26 Feb 2015 12:35:32 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0

On 25/02/2015 18:16, Leon Alrae wrote:
> Hi,
> On 16/02/2015 18:17, Paolo Bonzini wrote:
>> This needs to go away sooner or later, but one complication is the
>> complex VFIO data structures that are modified in instance_finalize.
>> Take a shortcut for now.
> It looks like this commit introduced a race condition. QEMU segfaults
> very early in one of my tests where I boot Linux, and on one of my
> machines it's easier to reproduce than on the others.

This should be enough to fix it.  If it works for you I'll send a pull
request as soon as possible.

diff --git a/cpus.c b/cpus.c
index 1cd9867..7bed67b 100644
--- a/cpus.c
+++ b/cpus.c
@@ -1115,7 +1115,7 @@ bool qemu_in_vcpu_thread(void)

 void qemu_mutex_lock_iothread(void)
-    if (!tcg_enabled()) {
+    if (!tcg_enabled() || !first_cpu) {
     } else {
         iothread_requesting_mutex = true;


reply via email to

[Prev in Thread] Current Thread [Next in Thread]