[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH 06/14] NBD client: connect to nbd server lat
Re: [Qemu-devel] [RFC PATCH 06/14] NBD client: connect to nbd server later
Thu, 26 Feb 2015 15:07:34 +0100
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0
On 25/02/2015 15:22, Max Reitz wrote:
> 3. nbd_co_discard()
> quorum doens't call bdrv_co_discard(), so it is OK to return -EIO here.
That can change, so I think you should return -EIO either everywhere or
nowhere. Which probably means nowhere.
> Hm, okay. How about adding an option to quorum for ignoring errors from
> a specific child? It's probably not possible to do something like
> "children.1.ignore-errors=true", but maybe you can just ignore errors in
> quorum from any but the first child if the read pattern is set to
> "first", that would make sense to me.
> But if you don't want to do that, I guess just making NBD some kind of
> /dev/null before it's connected should be fine.
I think what Wen is doing is okay, especially since it's only the
special nbd+colo:// URIs that are acting as /dev/null.
[Qemu-devel] [RFC PATCH 09/14] block: give backing image its own BlockBackend, Wen Congyang, 2015/02/11
[Qemu-devel] [RFC PATCH 07/14] NBD client: implement block driver interfaces for block replication, Wen Congyang, 2015/02/11
[Qemu-devel] [RFC PATCH 10/14] allow the backing image access the origin BlockDriverState, Wen Congyang, 2015/02/11
[Qemu-devel] [RFC PATCH 11/14] allow writing to the backing file, Wen Congyang, 2015/02/11
- Re: [Qemu-devel] [RFC PATCH 04/14] Add new block driver interfaces to control disk replication, (continued)