[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PULL 08/11] linux-user: Check for cpu_init() errors

From: Peter Maydell
Subject: Re: [Qemu-devel] [PULL 08/11] linux-user: Check for cpu_init() errors
Date: Fri, 27 Feb 2015 07:44:29 +0900

On 27 February 2015 at 01:06, Eduardo Habkost <address@hidden> wrote:
> On Thu, Feb 26, 2015 at 08:27:12AM +0900, Peter Maydell wrote:
>> Rather than bailing out here, it would be better to
>> propagate the failure out to the caller, which can
>> then fail the fork syscall it's trying to emulate
>> by returning a suitable error code to the guest.
> Makes sense to me, but I would prefer that to be done by somebody
> faimilar with the *-user code as a follow-up. My intention was to simply
> fix the bug so that QEMU won't crash.

When can it actually fail? Have you seen it do this in practice?
(Note that this is only called from fork, so we know that
cpu_model must be valid, or we would have failed on startup
trying to create the CPU for the initial thread.)

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]