[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH V2 08/11] virtio-pci: switch to use bus specific

From: Jason Wang
Subject: Re: [Qemu-devel] [PATCH V2 08/11] virtio-pci: switch to use bus specific queue limit
Date: Fri, 27 Feb 2015 03:26:44 +0008

On Thu, Feb 26, 2015 at 6:20 PM, Michael S. Tsirkin <address@hidden> wrote:
On Thu, Feb 26, 2015 at 03:04:43PM +0800, Jason Wang wrote:
 Instead of depending on a macro, switch to use a bus specific queue
Cc: Anthony Liguori <address@hidden>
 Cc: Michael S. Tsirkin <address@hidden>
 Signed-off-by: Jason Wang <address@hidden>
  hw/virtio/virtio-pci.c | 10 +++++-----
  1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c
 index 7fa8141..23c4649 100644
 --- a/hw/virtio/virtio-pci.c
 +++ b/hw/virtio/virtio-pci.c
@@ -215,7 +215,7 @@ static void virtio_pci_start_ioeventfd(VirtIOPCIProxy *proxy)
- for (n = 0; n < VIRTIO_PCI_QUEUE_MAX; n++) {
 +    for (n = 0; n < virtio_get_queue_max(vdev); n++) {
          if (!virtio_queue_get_num(vdev, n)) {

This is done on guest IO, and I think after applying the
next patch which increases the number to >500 for pci, it's too much
work: VCPU is blocked meanwhile. Same applies to other places.

At minimum, we'll need a faster way to locate active VQs.

Maybe just replace the continue with break in above. Since it looks like virtqueue index used by all virtio devices are contiguous?

reply via email to

[Prev in Thread] Current Thread [Next in Thread]